Add ProofModeM monad #114
Merged
Add ProofModeM monad #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackieLoeffel
force-pushed
the
msammler/proofmodem
branch
5 times, most recently
from
6d37bd8 to
d2ac0c7
Compare
Add a ProofModeM monad that automates the goal management of proof mode tactics. This subsumes the previous `Goals` structure.
MackieLoeffel
force-pushed
the
msammler/proofmodem
branch
from
d2ac0c7 to
a510b07
Compare
Collaborator
|
Great work! Please let me know when you think the PR is ready for review. I’ll have a look. |
MackieLoeffel
force-pushed
the
msammler/proofmodem
branch
from
86f8748 to
9a8a1b7
Compare
Collaborator
Author
|
I changed this PR to only have the proof mode changes and I will create new PRs for the other changes. @lzy0505 This is ready for you to review. |
Collaborator
|
It looks really good! I’ve added docstrings to ProofModeM functions and made some small stylistic changes. Ready to merge if you think these are fine. |
Collaborator
Author
|
Thanks for the review and the added comments! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #109
Add a ProofModeM monad that automates the goal management of proof
mode tactics. This subsumes the previous
Goalsstructure.